From 0a210b4e7e4b1f17fcca3594082eb2e1ad9fd414 Mon Sep 17 00:00:00 2001 From: Nathan Fisher Date: Tue, 22 Aug 2023 13:17:54 -0400 Subject: [PATCH] Fix UB in `load_sha256` test caused by accessing incorrect union field --- linkmap.c | 2 +- test/load_sha256.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/linkmap.c b/linkmap.c index 726c60a..5445419 100644 --- a/linkmap.c +++ b/linkmap.c @@ -150,7 +150,7 @@ char* haggis_linkmap_get_or_add(haggis_linkmap *map, ino_t inode, char * path) { ino_t val; u8 bytes[sizeof(ino_t)]; } key; - char * target = NULL; + char * target = ""; size_t idx, hash; haggis_bucket *b; diff --git a/test/load_sha256.c b/test/load_sha256.c index 6a35380..d01c1d0 100644 --- a/test/load_sha256.c +++ b/test/load_sha256.c @@ -13,7 +13,7 @@ int main() { if (haggis_load_cksum(f, &cksum)) return 1; assert(cksum.tag == sha256); for (i = 0; i < 32; i++) { - assert(cksum.sum.sha1[i] == (uint8_t)i); + assert(cksum.sum.sha256[i] == (uint8_t)i); } fclose(f); }